Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KNI] fix commit check #204

Merged
merged 1 commit into from
Jun 4, 2024
Merged

[KNI] fix commit check #204

merged 1 commit into from
Jun 4, 2024

Conversation

ffromani
Copy link
Member

@ffromani ffromani commented Jun 4, 2024

The env var COMMITS may be empty. Handle it accordingly.

@openshift-ci openshift-ci bot requested review from swatisehgal and Tal-or June 4, 2024 07:57
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2024
hack-kni/verify-commits.sh Outdated Show resolved Hide resolved
The env var `COMMITS` may be empty. Handle it accordingly.

Signed-off-by: Francesco Romani <[email protected]>
@ffromani ffromani force-pushed the fix-commit-check branch from 1912798 to 68af65c Compare June 4, 2024 08:23
@Tal-or
Copy link
Collaborator

Tal-or commented Jun 4, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2024
Copy link

openshift-ci bot commented Jun 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 115d656 into master Jun 4, 2024
7 checks passed
@ffromani ffromani deleted the fix-commit-check branch June 4, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants